Unify ble manager for silabs platforms #702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts common BLE manager functionality into an abstract base class, simplifying platform-specific implementations. Co-authored-by: arunkumar.padakanti <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the BLEManager implementation for the Silabs platform to reduce code duplication between the efr32 and rs911x variants.
AbstractBLEManagerImplto consolidate shared BLE manager state, initialization, and delegate helpers. This centralizes common logic, preventing its duplication across different platform implementations.BLEManagerImplclasses to inherit fromAbstractBLEManagerImpl, implementing only platform-specific methods such asPlatformInitandPostDriveBLEState.src/platform/silabs/AbstractBLEManagerImpl.cpp) to the relevant GN build targets for both efr32 and SiWx917.Related issues
N/A
Testing
Manual testing was not performed due to environment limitations. Build verification with
gn format/gn genand a full build is recommended to confirm the refactor integrates cleanly.Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines